refactor: repo structure #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xAustrian
reviewed
Aug 27, 2024
| import {ERC20} from "solady/tokens/ERC20.sol"; | ||
| // Interfaces | ||
| import "./interfaces/IRegistry.sol"; | ||
| import {IRegistry} from "./interfaces/IRegistry.sol"; |
There was a problem hiding this comment.
(This can be in another PR) Would be cool to remove relative paths and just use the remappings.
There was a problem hiding this comment.
100% I started changing but it was popping up more issues on certain contracts so I left for an other PR the rest. I will open a ticket
0xAustrian
approved these changes
Aug 28, 2024
ilpepepig
reviewed
Aug 28, 2024
0xAustrian
approved these changes
Aug 28, 2024
ilpepepig
approved these changes
Aug 28, 2024
thelostone-mc
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The restructure of the repo is described here: https://www.notion.so/defi-wonderland/Repository-Restructure-b63179e113884c79b6f797f5db940109
Also updated remappings and imports.
Decided to delete a lot of test files and test helper contracts and mocks from strategies that are in the
deprecatedfolder. Things get complex if we try to have tests for old and new strategies.v2.1should only include tests for core and the refactored strategies, extensions and libraries.