signer: Only merge multisigs if there are more than 1 #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
acfunk
changed the title
acfunk
changed the title
acfunk
changed the title
|
I added a unit test here to confirm that this fixes the bug: https://github.com/acfunk/js-algorand-sdk/pull/2 |
Add test for multisig signer
algochoi
approved these changes
Sep 1, 2023
| @@ -1,5 +1,15 @@ | |||
| /* eslint-env mocha */ | |||
| import assert from 'assert'; | |||
| import { | |||
There was a problem hiding this comment.
Note to any other reviewers: these just organize the imports (they are non-functional changes)
Eric-Warehime
approved these changes
Sep 1, 2023
winder
changed the title
|
Thanks for the contribution @acfunk ! |
joe-p
pushed a commit
to joe-p/js-algorand-sdk
that referenced
this pull request
Apr 11, 2024
Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the ATC signer to create multisigs with a single signature.