Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrap ProcessDispatcher.dispatch into FakePopenWrapper #170

Merged
merged 2 commits into from
Oct 3, 2024
Merged

wrap ProcessDispatcher.dispatch into FakePopenWrapper #170

merged 2 commits into from
Oct 3, 2024

Conversation

meeshal
Copy link
Contributor

@meeshal meeshal commented Oct 2, 2024

  • patching subprocess.Popen with ProcessDispatcher.dispatch causes TypeError when Popen is used as a type. Wrapped it into FakePopenWrapper instead.

@meeshal
Copy link
Contributor Author

meeshal commented Oct 2, 2024

Closes #155

@aklajnert aklajnert merged commit 9aacf03 into aklajnert:master Oct 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meeshal @aklajnert