Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated max-width to fix overlap error #1895

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Choromanski
Copy link
Contributor

  • I agree to license my contribution under LGPL-3.0 or my contribution is from another project with a license compatible with LGPL-3.0

To test this pull request, follow the instructions in the wiki.


Solution for #1821

Before:
image

After:
image

@Choromanski Choromanski marked this pull request as ready for review October 24, 2023 17:45
@ajayyy
Copy link
Owner

ajayyy commented Nov 1, 2023

How does this look with the popup in the browser top right

@Choromanski
Copy link
Contributor Author

Choromanski commented Nov 1, 2023

Before:

image

After:

image

I'll experiment with other solutions.

@ajayyy
Copy link
Owner

ajayyy commented Nov 1, 2023

Related #1429

@Choromanski
Copy link
Contributor Author

Issue #1429 results in the text running off the side of the page and can probably be closed:
image

@Choromanski
Copy link
Contributor Author

The discrepancy between youtube popup and browser popup is caused by the scrollbar, how do you feel about potentially removing the scrollbar but keeping scrolling functionality?

@ajayyy

@ajayyy
Copy link
Owner

ajayyy commented Nov 1, 2023

Hiding scrollbars is generally bad for accessibility, so I don't think it should be done. That may be why I never noticed it because I use Linux and have a very slim scrollbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants