Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add development.in #200

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add development.in #200

wants to merge 3 commits into from

Conversation

songmeo
Copy link

@songmeo songmeo commented Jul 10, 2020

What do these changes do?

I add development.in to requirements folder.

Are there changes in behavior for the user?

no they aren't. Just to differentiate between direct dependencies and others.

Related issue number

issue #181

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@Arfey
Copy link
Member

Arfey commented Jul 17, 2020

Hi. Thx for ur contribution. I think that we don't need pip-tools for develop our template. But it'll so good for users who use create-aio-app. So instead move requirements-dev.txt what do u think about to do the same with this files https://github.com/aio-libs/create-aio-app/tree/master/create_aio_app/template/%7B%7Bcookiecutter.project_name%7D%7D/requirements?

What do u think about it? 😀

@songmeo
Copy link
Author

songmeo commented Jul 17, 2020

What do you think?

@Arfey
Copy link
Member

Arfey commented Jul 17, 2020

Sorry, but i don't understand what u wanna do. In issues which u attached to current pull request described about dependence which exist in this directory
create-aio-app/create_aio_app/template/{{cookiecutter.project_name}}/requirements/
These dependence will use in project which create create-aio-app tool. Now, users use make update command for update these but main idea it drop check-requirements.py and use pip-tool instead.

@songmeo
Copy link
Author

songmeo commented Jul 18, 2020

hello, sorry I didn't get it in the first place. What do you think of these changes now?

psycopg2-binary==2.8.4
alembic==1.4.1
aioredis==1.3.1
uvloop==0.14.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In production.txt u can see that we don't add all requirements.

{%- if cookiecutter.use_postgres == 'y' %}
aiopg[sa]==1.0.0
...
{%- endif %}

it's important and we need to move this logic to .in files too.

@@ -0,0 +1,39 @@
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like input from pip-compile, are u sure that it's correct for .in file?

Sphinx==2.4.4
sphinx-autodoc-typehints==1.10.3
sphinxcontrib-websupport==1.2.0
doc8==0.8.0


echo(click.style("\n\nSuccessfully generated!\n", fg="bright_green",))
echo("cd " + click.style(f"{folder}/", fg="bright_blue"))
show_commands(folder)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this part (main.py, constants.py, __init__.py) connected with pip-tools?

@Arfey Arfey mentioned this pull request Aug 17, 2020
3 tasks
@CLAassistant
Copy link

CLAassistant commented Nov 16, 2020

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants