Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutex around step callback #67

Closed
eeberhard opened this issue Feb 12, 2024 · 1 comment · Fixed by #69 or #85
Closed

Add mutex around step callback #67

eeberhard opened this issue Feb 12, 2024 · 1 comment · Fixed by #69 or #85
Assignees

Comments

@eeberhard
Copy link
Member

After discoveries in https://github.com/aica-technology/stag/issues/7, there is a chance that the DSE state event handler unloads a component in one thread while the component step function is being handled in another thread. This race condition can cause memory issues and crashes.

Adding a mutex around the component step callback and the destructor could safeguard this race condition in a general way.

@domire8
Copy link
Member

domire8 commented Apr 18, 2024

Reopening this, since we need to revert the revert commit once we are ready for a breaking 5.0.0 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants