handle error correctly

ahmedsaheed · Jun 30, 2022 · b79fafb · b79fafb
1 parent ee6dcbc
commit b79fafb
Showing 1 changed file with 14 additions and 9 deletions.
diff --git a/src/main/java/quranCLI.java b/src/main/java/quranCLI.java
@@ -71,15 +71,7 @@ protected static String makeRequest(String url) throws IOException {
 
 
     public static void GetSurah(int surahNumber) throws IOException {
-        if (surahNumber > 114 || surahNumber < 1) {
-            System.out.println("Surah Number is not valid");
-            AsciiTable err = new AsciiTable();
-            err.addRule();
-            err.addRow("Surah Number is not valid, try in range 1 to 114").setTextAlignment(TextAlignment.CENTER);
-            err.addRule();
-            System.out.println(err.render());
-            System.exit(0);
-        }
+        SurahNumErr(surahNumber);
         String url = "https://api.alquran.cloud/v1/surah/" + surahNumber;
         StringBuilder verses = new StringBuilder();
         AsciiTable at = new AsciiTable();
@@ -135,6 +127,7 @@ public static String getAudio(int surahNumber) throws IOException {
     }
 
     public static String getEnglishTranslation(int surahNumber){
+        SurahNumErr(surahNumber);
         String url = "https://api.alquran.cloud/v1/surah/"+surahNumber+"/en.ahmedraza";
         AsciiTable at = new AsciiTable();
         try{
@@ -160,6 +153,18 @@ public static String getEnglishTranslation(int surahNumber){
         }
     }
 
+    private static void SurahNumErr(int surahNumber) {
+        if (surahNumber > 114 || surahNumber < 1) {
+            System.out.println("Surah Number is not valid");
+            AsciiTable err = new AsciiTable();
+            err.addRule();
+            err.addRow("Surah Number is not valid, try in range 1 to 114").setTextAlignment(TextAlignment.CENTER);
+            err.addRule();
+            System.out.println(err.render());
+            System.exit(0);
+        }
+    }
+
     public static void getAudioTranslation(int surahNumber) throws IOException {
         String url = "https://api.alquran.cloud/v1/surah/"+surahNumber+"/en.walk";
         String responses = makeRequest(url);