Redesign meta #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it should correspond to the value that a decorator will return.
Well... it seems that both target and context must be specified this way, to ensure that previous solution is respected. Not sure if this should be abstracted away from the Repository.
This should make it easier to describe the return value(s) for decorator related utils.
This will allow reducing the "context" parameter for some of the internal helper methods.
A new Meta Repository class is now responsible for reading and writing metadata. This should make it a lot easier for other developers to create their own "meta" version, if needed.
To be used by the "inheritTargetMeta()" util.
Added new TargetMetaRepository that handles the "targetMeta" logic. Furthermore, also added hasTargetMeta() util, and moved all target meta related components into the "target" sub-directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains a refactored / redesigned version the util functions offered by
@aedart/support/meta. A newMetaRepositoryandTargetMetaRepositoryare now used underneath. The API has not changed¹.¹:
targetMeta()andinheritTargetMeta()now throwMetaErrorinstead of previousTypeError. This should have a low impact, because both utils are intended to be used as class and class method decorators.Details
Details are available in the
CHANGELOG.md.