Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed problem with ambiguous dotenv naming #22

Closed
wants to merge 1 commit into from
Closed

Fixed problem with ambiguous dotenv naming #22

wants to merge 1 commit into from

Conversation

techbech
Copy link

@techbech techbech commented Dec 20, 2020 •
edited
Loading

First off, thank you for the library. I'm happy to see dotenv in cpp :-)

This is a fix for issue #21

I've renamed the dotenv class to dotenvFacade as the purpose of the class seemed to fit the facade pattern. Let me know if you would like the name changed to something else.

@techbech techbech mentioned this pull request Dec 20, 2020
Open
@adeharo9
Copy link
Owner

adeharo9 commented Jan 15, 2021 •
edited
Loading

Thanks for the suggestion, but it is a bit too verbose for my taste - personal opinion strictly speaking.

Check answer to #21 for more discussion.

@techbech
Copy link
Author

Thanks for the suggestion, but it is a bit too verbose for my taste - personal opinion strictly speaking.

Fair ✌️

@techbech techbech closed this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@techbech @adeharo9