Fix memory leak on failure to open #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes leak of memory caused by failure to free file and directory structures when open fails.
Clearing `_file` and `_dir` pointers after freeing on failure to open just in case close() is later called. To elaborate, the `_file` and `_dir` pointers are normally freed and cleared by _close(), but when a failure occurs upon opening, these pointers were being left orphaned since calling close() after failure to open doesn't make much sense, and indeed caused serious issues within lfs.
hathach
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes leak of memory caused by failure to free file and directory structures when open fails.