Bug #1, fix to travis YAML file; PHP fixes via CodeClimate

.gitignore

@@ -12,7 +12,6 @@ vendor/*
 test/node_modules/*
 
 *BAK*
-.DS_Store
 
 
 #End.

.travis.yml

@@ -14,6 +14,9 @@ install:
   - composer install
   - composer install-npm
 
+before_script:
+  - cp app.TEMPLATE.yaml app.yaml
+
 script:
   - composer test
 

README.md

@@ -1,4 +1,6 @@
 
+[![Build status – Travis-CI][travis-icon]][travis]
+
 # AccessifyWiki-API
 
 Portable/ Google App Engine hosted PHP-based API for AccessifyWiki accessibility fixes.
@@ -40,5 +42,8 @@ composer deploy
 [@nfreear/wp-accessify]: https://github.com/nfreear/wp-accessify "WordPress plugin"
 [@nfreear/accessify-client-php]: https://github.com/nfreear/accessify-client-php "PHP client library"
 
+[travis]: https://travis-ci.org/accessifywiki/accessifywiki-api
+[travis-icon]: https://travis-ci.org/accessifywiki/accessifywiki-api.svg "Build status – Travis-CI"
+
 
 [End]: //end.

composer.json

@@ -20,11 +20,9 @@
     "jakub-onderka/php-parallel-lint": "^0.9.2"
   },
   "suggest": {
-    "slim/slim": "^2.6",
     "slim/slim::3": "^3.0; Requires PHP >=5.5 :(",
     "silex/silex": "^1.3",
-    "devster/frontmatter": "^1.0@dev",
-    "kzykhys/yaml-front-matter": "^1.0"
+    "devster/frontmatter": "^1.0@dev"
   },
   "autoload": {
     "psr-4": {

src/App.php

@@ -48,12 +48,11 @@ private static function setErrorHandler()
     }
 
 
-    public function jsonOLD($obj, $response = null)  //OLD.
+    public function jsonOLD($obj, Response $response = null)  //OLD.
     {
         $response = $response ? $response : $this->response;  //???
 
-        $callback = $this->getParam('callback');
-        $callback = preg_match('/^[a-z_][\w\._]+$/', $callback) ? $callback : null;
+        $callback = $this->getValidCallback();
 
         $response = $response->withHeader('Access-Control-Allow-Origin', '*');
         $response = $response->withHeader('Content-Type', 'application/json; charset=utf-8');
@@ -77,7 +76,7 @@ private function getValidCallback()
         return $callback && preg_match(self::CALLBACK_REGEX, $callback) ? $callback : null;
     }
 
-    public function getRequiredUrl(&$response)
+    public function getRequiredUrl(Response &$response)
     {
         $url = $this->getParam('url', FILTER_VALIDATE_URL);
         if (! $url) {

src/DotEnvMiddleware.php

@@ -25,7 +25,7 @@ class DotEnvMiddleware
      *
      * @return \Psr\Http\Message\ResponseInterface
      */
-    public function __invoke($request, $response, $next)
+    public function __invoke(Request $request, Response $response, $next)
     {
         try {
             if (self::envIsTrue('aw_use_dotenv')) {
@@ -35,7 +35,7 @@ public function __invoke($request, $response, $next)
             } else {
                 $this->testGoogeAppEngineVariables();
             }
-        } catch (Exception $ex) {
+        } catch (\Exception $ex) {
             header('HTTP/1.1 500');
             header('X-AW-Debug-00', 'dotenv = fail' . $ex->getMessage());
             echo 'Dotenv error! '. $ex->getMessage();

src/GitHub.php

@@ -8,7 +8,6 @@
  */
 
 use \GuzzleHttp\Client;
-use \Symfony\Component\Yaml\Yaml;
 
 class GitHub
 {

test/validate-app-yaml.php

@@ -19,6 +19,5 @@
 }
 
 fprintf(STDERR, "OK. YAML file parsed: '%s' - %s\n", $e->getMessage(), $yaml_file);
-exit(0);
 
 #End.