Выполненое Задание №1 #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexKitIt
reviewed
Sep 29, 2024
tests/bun_test.py
Outdated
Comment on lines
10
to
12
| def test_bun_initialization(self, name, price): | ||
| bun = Bun(name, price) | ||
| assert bun.get_name() == name and bun.get_price() == price |
There was a problem hiding this comment.
Нужно исправить: это юнит тесты, должен быть отдельный тест на отдельный метод
AlexKitIt
reviewed
Sep 29, 2024
tests/conftest.py
Outdated
Comment on lines
13
to
28
| mock_bun = Mock(spec=Bun) | ||
| mock_bun.get_name.return_value = MockBurger.BUN_NAME | ||
| mock_bun.get_price.return_value = MockBurger.BUN_PRICE | ||
|
|
||
| mock_ingredient = Mock(spec=Ingredient) | ||
| mock_ingredient.get_price.return_value = MockBurger.INGREDIENT_PRICE | ||
| mock_ingredient.get_name.return_value = MockBurger.INGREDIENT_NAME | ||
| mock_ingredient.get_type.return_value = MockBurger.INGREDIENT_TYPE | ||
|
|
||
| another_mock_ingredient = Mock(spec=Ingredient) | ||
| another_mock_ingredient.get_price.return_value = MockBurger.ANOTHER_INGREDIENT_PRICE | ||
| another_mock_ingredient.get_name.return_value = MockBurger.ANOTHER_INGREDIENT_NAME | ||
| another_mock_ingredient.get_type.return_value = MockBurger.ANOTHER_INGREDIENT_TYPE | ||
|
|
||
| # Инициализируем бургер с булочкой | ||
| burger = Burger() |
There was a problem hiding this comment.
Можно лучше: очень сложный объект, стоит создавать несколько более маленьких объектов с локальной логикой, чтобы не пришлось это отправлять в каждый тест а использовать только 1 или 2 элемента из кортежа
AlexKitIt
reviewed
Sep 29, 2024
tests/ingredient_test.py
Outdated
| @pytest.mark.parametrize("ingredient_type, name, price", IngredientData.INGREDIENT_DATA) | ||
| def test_ingredient_initialization(self, ingredient_type, name, price): | ||
| ingredient = Ingredient(ingredient_type, name, price) | ||
| assert ingredient.get_type() == ingredient_type and ingredient.get_name() == name and ingredient.get_price() == price |
There was a problem hiding this comment.
Нужно исправить: это тоже должно быть три отдельных теста
…о лучше". Направляю обновленную версию.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.