First commit #191

Bars0013 · 2024-09-04T11:17:00Z

No description provided.

AlexKitIt · 2024-09-04T18:00:28Z

conftest.py

+@pytest.fixture
+def mock_bun():
+    return Mock()
+
+
+@pytest.fixture
+def mock_ingredient():
+    return Mock()


Нужно исправить: чем отличаются эти две фикстуры? Либо наполняем тут мок, либо оставляем одну

AlexKitIt · 2024-09-04T18:01:09Z

tests/test_ingredient.py

+    @pytest.mark.parametrize("ingredient_type", [INGREDIENT_TYPE_SAUCE, INGREDIENT_TYPE_FILLING])
+    def test_get_type_success(self, ingredient_type):
+        ingredient = Ingredient(ingredient_type, Data.INGREDIENT_NAME, Data.INGREDIENT_PRICE)
+        expected_type = 'SAUCE' if ingredient_type == INGREDIENT_TYPE_SAUCE else 'FILLING'


Нужно исправить: условий в тестах быть не может, тест всегда однозначен

First commit

dc36384

AlexKitIt reviewed Sep 4, 2024

View reviewed changes

Second commit

63db798

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First commit #191

First commit #191

Bars0013 commented Sep 4, 2024

AlexKitIt Sep 4, 2024

AlexKitIt Sep 4, 2024

First commit #191

Are you sure you want to change the base?

First commit #191

Conversation

Bars0013 commented Sep 4, 2024

AlexKitIt Sep 4, 2024

Choose a reason for hiding this comment

AlexKitIt Sep 4, 2024

Choose a reason for hiding this comment