Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Проектная работа по котлин #163

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Проектная работа по котлин #163

wants to merge 2 commits into from

Conversation

AlekseyChist
Copy link

No description provided.

Grigoriy-M
Grigoriy-M reviewed Jun 11, 2024
View reviewed changes
src/main/kotlin/Archive.kt
@@ -0,0 +1,4 @@
data class Archive (
val name: String,
val notes: MutableList<Note>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лучше не делать мутабельные сущности в data class, т.к. сама суть дата класса хранить данные.

Grigoriy-M
Grigoriy-M reviewed Jun 11, 2024
View reviewed changes
src/main/kotlin/Functions.kt
@@ -0,0 +1,100 @@
import java.util.Scanner

class Functions(val choiceSelection: Choice) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

choiceSelection сделай приватной.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

окей

@AlekseyChist
Copy link
Author

Спасибо, учту пожелания!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grigoriy-M Grigoriy-M Grigoriy-M left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekseyChist @Grigoriy-M