Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remy 1.8.2 - Improve DuckType Get for factory + lazy singletone injections #14

Merged
merged 9 commits into from
Jul 11, 2024

Conversation

Jictyvoo
Copy link
Member

  • Update GetAll method (and also duck type get) to retrieve objects stored as Bind[T]
    • This update add a little more overhead to check if the bind implements the type we're searching for
    • Created a new function on Binds to try to prevent stack-overflow and cycle dependency get
    • If everything matches, this new way of returning duck-type elements will call the Generate method on bind
      • It must be very careful about cycle dependencies now more than ever
  • Add tests to cover the new duckType mode with Bind[T]

@Jictyvoo Jictyvoo added the enhancement New feature or request label May 26, 2024
@Jictyvoo Jictyvoo self-assigned this May 26, 2024
@Jictyvoo Jictyvoo merged commit b425d50 into main Jul 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant