Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 2 NREs related to assets #427

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

probablykory
Copy link
Contributor

Fix for 2 NREs that seem to occur while running Jotunn mods alongside Krumpac's Reforged modpack.

JotunnLib/Managers/PrefabManager.cs Outdated Show resolved Hide resolved
JotunnLib/Managers/PrefabManager.cs Outdated Show resolved Hide resolved
@probablykory
Copy link
Contributor Author

probablykory commented Apr 29, 2024

Tested normal operation (0.217.46 with MoreCrossbows and Jotunn), and this change seems to be benign. Tested with Reforged, and with the change it works fine. Without the change (eg tested with Jotunn 2.19.3 to verify) it does indeed throw an NRE.

[Error  :Jotunn.Managers.GUIManager] System.NullReferenceException: Object reference not set to an instance of an object
  at Jotunn.Managers.PrefabManager+Cache.GetPrefab (System.Type type, System.String name) [0x0002a] in D:\Projects\Jotunn\JotunnLib\Managers\PrefabManager.cs:444
  at Jotunn.Managers.PrefabManager+Cache.GetPrefab[T] (System.String name) [0x00000] in D:\Projects\Jotunn\JotunnLib\Managers\PrefabManager.cs:472
  at Jotunn.Managers.GUIManager.InitializeAssets () [0x002ec] in D:\Projects\Jotunn\JotunnLib\Managers\GUIManager.cs:423

Full log attached.

@MSchmoecker
Copy link
Member

thanks, looks good now

@MSchmoecker MSchmoecker merged commit 5ed1b0c into Valheim-Modding:dev Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants