Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenderManager: parse dependencies of subtype #425

Merged
merged 2 commits into from
Mar 28, 2024
Merged

RenderManager: parse dependencies of subtype #425

merged 2 commits into from
Mar 28, 2024

Conversation

bid-soft
Copy link
Contributor

As discussed on discord. Parsing subtype dependencies for RenderManager.
I have not been able to test it, as I was not able to reproduce the original error with ?jewelcrafting?.

MSchmoecker
MSchmoecker approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@MSchmoecker MSchmoecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can confirm the original issue is fixed, too. The setup is a bit complicated, you'd need VNEI, Jewelcrafting and clear the icon cache so a re render is triggered.

@MSchmoecker MSchmoecker merged commit 4a3f1f0 into Valheim-Modding:dev Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSchmoecker MSchmoecker MSchmoecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bid-soft @MSchmoecker