fix: modify GetOrAddComponent to use TryGetComponent. #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Null-coalescing operators do not work properly on Unity objects. See: https://stackoverflow.com/q/76294124
MSchmoecker
approved these changes
Sep 16, 2023
|
Thank you. Does this fix an edge case in some mods or is it a general improvement? I.e. should we push a fix for this or can it be part of the next update? |
|
Just a general improvement. I'll be submitting a few more performance improvements for GUIManager as well. Can all be pushed as part of an update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null-coalescing operators do not work properly on Unity objects.
See: https://stackoverflow.com/q/76294124
Also it removed the BOM for some reason.