Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ping #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion files/jupyterhub/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ RUN wget https://get.docker.com -q -O /tmp/getdocker && \
chmod +x /tmp/getdocker && \
sh /tmp/getdocker && \
rm /tmp/getdocker && \
apt-get -y clean && apt-get -y autoremove
apt-get -y clean && apt-get -y autoremove && \
apt-get install iputils-ping
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add this into line 21 so maybe line 21 changes to:

apt-get -y install iputils-ping && \
    apt-get -y clean && \
    apt-get -y autoremove

The Travis build failed because the -y flag needs to be included in the install command to automatically tell the installer that yes, you want this to install non-interactively.


# Install the Docker Swarm spawner
RUN git clone https://github.com/isuftin/SwarmSpawner /tmp/SwarmSpawner && \
Expand Down