fix(shadcn-ui): Rename add executor to add-component

packages/firebase-hosting/src/executors/deploy/deploy.impl.ts

@@ -7,26 +7,25 @@ export interface ExecutorSchema {
   message?: string
 }
 
-export function deployExecutor(
+export async function deployExecutor(
   options: ExecutorSchema
   // context: ExecutorContext
 ): Promise<{ success: boolean }> {
   // Make sure the deployment target is defined
   execPackageManagerCommand(buildCommand([
-    'firebase target:apply',
+    'firebase-tools target:apply',
     `hosting ${options.site} ${options.identifier || options.site}`,
 
     options.project && `--project=${options.project}`
   ]))
 
-  return Promise.resolve(execPackageManagerCommand(buildCommand([
-      'firebase deploy',
-      `--only=hosting:${options.site}`,
+  return execPackageManagerCommand(buildCommand([
+    'firebase-tools deploy',
+    `--only=hosting:${options.site}`,
 
-      options.project && `--project=${options.project}`,
-      options.message && `-m "${options.message}"`
-    ])
-  ))
+    options.project && `--project=${options.project}`,
+    options.message && `-m "${options.message}"`
+  ]))
 }
 
 export default deployExecutor

packages/shadcn-ui/migrations.json

@@ -0,0 +1,9 @@
+{
+  "generators": {
+    "change-add-executor": {
+      "version": "1.1.1",
+      "description": "'add' executor became reserved, changed to 'add-component'.",
+      "implementation": "./src/migrations/change-add-executor/change-add-executor"
+    }
+  }
+}

packages/shadcn-ui/src/generators/init/init.impl.ts

@@ -96,7 +96,7 @@ export default async function (tree: Tree, options: ShadecnUiSchema) {
   updateProjectConfiguration(tree, uiLibOptions.projectName, {
     ...readProjectConfiguration(tree, uiLibOptions.projectName),
     targets: {
-      add: {
+      'add-component': {
         executor: '@nx-extend/shadcn-ui:add'
       }
     }

packages/shadcn-ui/src/migrations/change-add-executor/change-add-executor.spec.ts

@@ -0,0 +1,60 @@
+import { addProjectConfiguration, readProjectConfiguration } from '@nx/devkit'
+import { createTreeWithEmptyWorkspace } from '@nx/devkit/testing'
+
+import type { Tree } from '@nx/devkit'
+
+import update from './change-add-executor'
+
+describe('change-function-gen migration', () => {
+  let tree: Tree
+
+  beforeEach(() => {
+    tree = createTreeWithEmptyWorkspace()
+  })
+
+  it('should run successfully', async () => {
+    addProjectConfiguration(tree, 'renamedAdd', {
+      root: 'renamedAdd',
+      targets: {
+        addComponent: {
+          executor: '@nx-extend/shadcn-ui:add'
+        }
+      }
+    })
+
+    addProjectConfiguration(tree, 'oldAdd', {
+      root: 'oldAdd',
+      targets: {
+        add: {
+          executor: '@nx-extend/shadcn-ui:add',
+          options: {
+            foo: 'bar'
+          }
+        }
+      }
+    })
+
+    await update(tree)
+
+    expect(readProjectConfiguration(tree, 'renamedAdd')).toEqual(expect.objectContaining({
+      root: 'renamedAdd',
+      targets: {
+        addComponent: {
+          executor: '@nx-extend/shadcn-ui:add'
+        }
+      }
+    }))
+
+    expect(readProjectConfiguration(tree, 'oldAdd')).toEqual(expect.objectContaining({
+      root: 'oldAdd',
+      targets: {
+        'add-component': {
+          executor: '@nx-extend/shadcn-ui:add',
+          options: {
+            foo: 'bar'
+          }
+        }
+      }
+    }))
+  })
+})

packages/shadcn-ui/src/migrations/change-add-executor/change-add-executor.ts

@@ -0,0 +1,22 @@
+import { Tree, updateProjectConfiguration } from '@nx/devkit'
+import { getProjects } from 'nx/src/generators/utils/project-configuration'
+
+/**
+ * Migrates all "add" targets with @nx-extend/shadcn-ui:add target to become "add-component"
+ */
+export default function update(tree: Tree) {
+  const projects = getProjects(tree)
+
+  for (const [name, project] of projects) {
+    const addTarget = Object.keys(project.targets).find((target) => (
+      project.targets[target].executor === '@nx-extend/shadcn-ui:add'
+    ))
+
+    if (addTarget && addTarget === 'add') {
+      project.targets['add-component'] = project.targets[addTarget]
+      delete project.targets[addTarget]
+
+      updateProjectConfiguration(tree, name, project)
+    }
+  }
+}