forked from FasterXML/jackson-databind
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix FasterXML#3503: Implement int-to-float coercion config
- Loading branch information
1 parent
480bc60
commit d4ad183
Showing
4 changed files
with
238 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
172 changes: 172 additions & 0 deletions
172
src/test/java/com/fasterxml/jackson/databind/convert/CoerceIntToFloatTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,172 @@ | ||
| package com.fasterxml.jackson.databind.convert; | ||
|
|
||
| import com.fasterxml.jackson.core.JsonProcessingException; | ||
| import com.fasterxml.jackson.databind.BaseMapTest; | ||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import com.fasterxml.jackson.databind.ObjectReader; | ||
| import com.fasterxml.jackson.databind.cfg.CoercionAction; | ||
| import com.fasterxml.jackson.databind.cfg.CoercionInputShape; | ||
| import com.fasterxml.jackson.databind.exc.MismatchedInputException; | ||
| import com.fasterxml.jackson.databind.type.LogicalType; | ||
| import java.math.BigDecimal; | ||
|
|
||
| public class CoerceIntToFloatTest extends BaseMapTest | ||
| { | ||
| private final ObjectMapper DEFAULT_MAPPER = newJsonMapper(); | ||
|
|
||
| private final ObjectMapper MAPPER_TO_FAIL = jsonMapperBuilder() | ||
| .withCoercionConfig(LogicalType.Float, cfg -> | ||
| cfg.setCoercion(CoercionInputShape.Integer, CoercionAction.Fail)) | ||
| .build(); | ||
|
|
||
| private final ObjectMapper MAPPER_TRY_CONVERT = jsonMapperBuilder() | ||
| .withCoercionConfig(LogicalType.Float, cfg -> | ||
| cfg.setCoercion(CoercionInputShape.Integer, CoercionAction.TryConvert)) | ||
| .build(); | ||
|
|
||
| private final ObjectMapper MAPPER_TO_NULL = jsonMapperBuilder() | ||
| .withCoercionConfig(LogicalType.Float, cfg -> | ||
| cfg.setCoercion(CoercionInputShape.Integer, CoercionAction.AsNull)) | ||
| .build(); | ||
|
|
||
| private final ObjectMapper MAPPER_TO_EMPTY = jsonMapperBuilder() | ||
| .withCoercionConfig(LogicalType.Float, cfg -> | ||
| cfg.setCoercion(CoercionInputShape.Integer, CoercionAction.AsEmpty)) | ||
| .build(); | ||
|
|
||
| public void testDefaultIntToFloatCoercion() throws JsonProcessingException | ||
| { | ||
| assertSuccessfulIntToFloatConversionsWith(DEFAULT_MAPPER); | ||
| } | ||
|
|
||
| public void testCoerceConfigToConvert() throws JsonProcessingException | ||
| { | ||
| assertSuccessfulIntToFloatConversionsWith(MAPPER_TRY_CONVERT); | ||
| } | ||
|
|
||
| public void testCoerceConfigToNull() throws JsonProcessingException | ||
| { | ||
| assertNull(MAPPER_TO_NULL.readValue("1", Float.class)); | ||
| // `null` not possible for primitives, must use empty (aka default) value | ||
| assertEquals(0.0f, MAPPER_TO_NULL.readValue("-2", Float.TYPE)); | ||
| { | ||
| FloatWrapper w = MAPPER_TO_NULL.readValue("{\"f\": -5}", FloatWrapper.class); | ||
| assertEquals(0.0f, w.f); | ||
| float[] arr = MAPPER_TO_NULL.readValue("[ 2 ]", float[].class); | ||
| assertEquals(1, arr.length); | ||
| assertEquals(0.0f, arr[0]); | ||
| } | ||
|
|
||
| assertNull(MAPPER_TO_NULL.readValue("-1", Double.class)); | ||
| assertEquals(0.0d, MAPPER_TO_NULL.readValue("4", Double.TYPE)); | ||
| { | ||
| DoubleWrapper w = MAPPER_TO_NULL.readValue("{\"d\": 2}", DoubleWrapper.class); | ||
| assertEquals(0.0d, w.d); | ||
| double[] arr = MAPPER_TO_NULL.readValue("[ -7 ]", double[].class); | ||
| assertEquals(1, arr.length); | ||
| assertEquals(0.0d, arr[0]); | ||
| } | ||
|
|
||
| assertNull(MAPPER_TO_NULL.readValue("420", BigDecimal.class)); | ||
| { | ||
| BigDecimal[] arr = MAPPER_TO_NULL.readValue("[ 420 ]", BigDecimal[].class); | ||
| assertEquals(1, arr.length); | ||
| assertNull(arr[0]); | ||
| } | ||
| } | ||
|
|
||
| public void testCoerceConfigToEmpty() throws JsonProcessingException | ||
| { | ||
| assertEquals(0.0f, MAPPER_TO_EMPTY.readValue("3", Float.class)); | ||
| assertEquals(0.0f, MAPPER_TO_EMPTY.readValue("-2", Float.TYPE)); | ||
| { | ||
| FloatWrapper w = MAPPER_TO_EMPTY.readValue("{\"f\": -5}", FloatWrapper.class); | ||
| assertEquals(0.0f, w.f); | ||
| float[] arr = MAPPER_TO_EMPTY.readValue("[ 2 ]", float[].class); | ||
| assertEquals(1, arr.length); | ||
| assertEquals(0.0f, arr[0]); | ||
| } | ||
|
|
||
| assertEquals(0.0d, MAPPER_TO_EMPTY.readValue("-1", Double.class)); | ||
| assertEquals(0.0d, MAPPER_TO_EMPTY.readValue("-5", Double.TYPE)); | ||
| { | ||
| DoubleWrapper w = MAPPER_TO_EMPTY.readValue("{\"d\": 2}", DoubleWrapper.class); | ||
| assertEquals(0.0d, w.d); | ||
| double[] arr = MAPPER_TO_EMPTY.readValue("[ -2 ]", double[].class); | ||
| assertEquals(1, arr.length); | ||
| assertEquals(0.0d, arr[0]); | ||
| } | ||
|
|
||
| assertEquals(BigDecimal.valueOf(0), MAPPER_TO_EMPTY.readValue("3643", BigDecimal.class)); | ||
| } | ||
|
|
||
| public void testCoerceConfigToFail() throws JsonProcessingException | ||
| { | ||
| _verifyCoerceFail(MAPPER_TO_FAIL, Float.class, "3"); | ||
| _verifyCoerceFail(MAPPER_TO_FAIL, Float.TYPE, "-2"); | ||
| _verifyCoerceFail(MAPPER_TO_FAIL, FloatWrapper.class, "{\"f\": -5}", "float"); | ||
| _verifyCoerceFail(MAPPER_TO_FAIL, float[].class, "[ 2 ]", "element of `float[]`"); | ||
|
|
||
| _verifyCoerceFail(MAPPER_TO_FAIL, Double.class, "-1"); | ||
| _verifyCoerceFail(MAPPER_TO_FAIL, Double.TYPE, "4"); | ||
| _verifyCoerceFail(MAPPER_TO_FAIL, DoubleWrapper.class, "{\"d\": 2}", "double"); | ||
| _verifyCoerceFail(MAPPER_TO_FAIL, double[].class, "[ -2 ]", "element of `double[]`"); | ||
|
|
||
| _verifyCoerceFail(MAPPER_TO_FAIL, BigDecimal.class, "73455342"); | ||
| } | ||
|
|
||
| /* | ||
| /******************************************************** | ||
| /* Helper methods | ||
| /******************************************************** | ||
| */ | ||
|
|
||
| private void assertSuccessfulIntToFloatConversionsWith(ObjectMapper objectMapper) | ||
| throws JsonProcessingException | ||
| { | ||
| assertEquals(3.0f, objectMapper.readValue("3", Float.class)); | ||
| assertEquals(-2.0f, objectMapper.readValue("-2", Float.TYPE)); | ||
| { | ||
| FloatWrapper w = objectMapper.readValue("{\"f\": -5}", FloatWrapper.class); | ||
| assertEquals(-5.0f, w.f); | ||
| float[] arr = objectMapper.readValue("[ 2 ]", float[].class); | ||
| assertEquals(2.0f, arr[0]); | ||
| } | ||
|
|
||
| assertEquals(-1.0d, objectMapper.readValue("-1", Double.class)); | ||
| assertEquals(4.0d, objectMapper.readValue("4", Double.TYPE)); | ||
| { | ||
| DoubleWrapper w = objectMapper.readValue("{\"d\": 2}", DoubleWrapper.class); | ||
| assertEquals(2.0d, w.d); | ||
| double[] arr = objectMapper.readValue("[ -2 ]", double[].class); | ||
| assertEquals(-2.0d, arr[0]); | ||
| } | ||
|
|
||
| BigDecimal biggie = objectMapper.readValue("423451233", BigDecimal.class); | ||
| assertEquals(BigDecimal.valueOf(423451233.0d), biggie); | ||
| } | ||
|
|
||
| private void _verifyCoerceFail(ObjectMapper m, Class<?> targetType, | ||
| String doc) throws JsonProcessingException | ||
| { | ||
| _verifyCoerceFail(m.reader(), targetType, doc, targetType.getName()); | ||
| } | ||
|
|
||
| private void _verifyCoerceFail(ObjectMapper m, Class<?> targetType, | ||
| String doc, String targetTypeDesc) throws JsonProcessingException | ||
| { | ||
| _verifyCoerceFail(m.reader(), targetType, doc, targetTypeDesc); | ||
| } | ||
|
|
||
| private void _verifyCoerceFail(ObjectReader r, Class<?> targetType, | ||
| String doc, String targetTypeDesc) throws JsonProcessingException | ||
| { | ||
| try { | ||
| r.forType(targetType).readValue(doc); | ||
| fail("Should not accept Integer for "+targetType.getName()+" when configured to"); | ||
| } catch (MismatchedInputException e) { | ||
| verifyException(e, "Cannot coerce Integer"); | ||
| verifyException(e, targetTypeDesc); | ||
| } | ||
| } | ||
| } |