-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: allow link to section mark #7744
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is a minor comment: The highlighted color would be nice to follow the palette in use. |
Some use cases:
|
Sure, I'm using the existing
I'm not sure if this is necessary, I will auto create id on target tiddler, when you write a link in another, when using the WYSIWYG editor (or maybe codemirror-enhannced), this is the UX of Obsidian. While it is reasonable to fall back to a menu button, if user is using empty edition, but that will have a huge UX gap between Obsidian.
Yes, it can be used to write footnotes and in refnotes. But its main purpose is for block-level backlinks, and block-level transclusion, like in Obsidian. We need to have all that they have!
I think Obsidian can only transclude a single block. I'm not sure if transclude syntax can be extended to reference 2 id to create a reference... |
I think this is good to go!
That is fine. Thank you |
@Jermolene Please review this again! A qq group member ask for paragraph level transclusion, but I can't implement it without this syntax. |
@Jermolene ... I think this PR would be a nice feature. |
@pmario: Somehow I missed this comment months ago:
While I will dig into the actual code when I'm not on mobile, I don't really see how this would be related. At a feature level, they don't have much in common. Are there similar implementation ideas? |
@Jermolene Could you check this request again? I really wish tiddlywiki would make this possible. |
@Jermolene Could you check this before 5.2.4? |
@Jermolene we need you to check this pr. |
Hi @linonetwo thank you for your continued work on this. I recognise that there is a strong user demand for anchors and I am keen to get them into the core. Two areas that I think need more work is documentation and tests. There should definitely be tests for the new parse rules, and it may be possible to create a rig so that the navigation can be tested too. I am also concerned how this implementation will work with static renderings. For example, anchor links should work within a static rendering such as https://tiddlywiki.com/alltiddlers.html. There are obviously some interactive features that we cannot support in static renderings, but basic link navigation needs to work as expected. |
This is block-level link. Prepare for block-level backlink.
(wait for #6081 so I can continue modify back-indexer)Add a new
^id
syntax, see #7537 for details.Also modify pretty wiki link's parsing rule to allow link to such an id. And modify link widget to allow id widget to react to link jumping.
(Currently, if
New Tiddler
is not currently opened,hookFocusElementEvent
can't highlight the element, I have to usesetTimeout
to wait for the dom element actually show. Is there a better solution?)And sadly, we can't use
#xxx
as ID, otherwise will encounterInvalid selector: ##BlockLevelLinksID1
Demo: https://tiddlywiki5-bsqd5sfir-jermolenes-projects.vercel.app/#Block%20Level%20Links%20in%20WikiText:%5B%5BBlock%20Level%20Links%20in%20WikiText%5D%5D%20%5B%5BLinking%20in%20WikiText%5D%5D