Nové funkcionality, novější věci! #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: robertsokola <robertsokola2@gmail.com>
Signed-off-by: robertsokola <robertsokola2@gmail.com>
Signed-off-by: robertsokola <robertsokola2@gmail.com>
Signed-off-by: robertsokola <robertsokola2@gmail.com>
Added Black formatter
Signed-off-by: robertsokola <robertsokola2@gmail.com>
Signed-off-by: robertsokola <robertsokola2@gmail.com>
…efore commiting to main Signed-off-by: robertsokola <robertsokola2@gmail.com>
## Popis:
Spravení error handlingu z
```py
if error_handling(answers):
return await message.edit(embed=PollEmbedBase(error_handling(answers)))
```
na
```py
if len(answer) > Poll.MAX_OPTIONS:
raise TooManyOptionsError(f"Zadal jsi příliš mnoho odpovědí, můžeš maximálně {Poll.MAX_OPTIONS}!")
```
## Proč?
Zvýšení čtitelnosti, jednodušší práce s error handlingem a přehlednost.
## Co dodělat?
- [x] #16
- New emoji class, inherited from Enum this time - Corrected embeds and errors for using the new emoji style - main.py has debug logger now - Now you can add new options using new button known bugs: - Raising errors in buttons/modals doesn't work properly due to a bug in attributes. Maybe raise an issue on discord.py pages Signed-off-by: robertsokola <robertsokola2@gmail.com>
Try to make a embed that displays whether a user added a new option Signed-off-by: robertsokola <robertsokola2@gmail.com>
Signed-off-by: robertsokola <robertsokola2@gmail.com>
…t commit should aim for tasks.loop and database overlay fixes. Signed-off-by: robertsokola <robertsokola2@gmail.com>
oprava pomoci black
- fixed bug with databases where two people clicking at the same time could break entire bot - added new functionality with looping, where the bot can check if the embed is due date - added new transformer for transferring dates, it's a little more dumbproof than previous versions - added new error handling... more beautiful! Signed-off-by: robertsokola <robertsokola2@gmail.com>
Signed-off-by: robertsokola <robertsokola2@gmail.com>
Signed-off-by: robertsokola <robertsokola2@gmail.com>
Pull request míří na úpravu anket podle issues. Zejména se jedná o tyto věci: - Přidání možnosti po vytvoření ankety - Anketa, když jí vyprší čas, by se měla automaticky smazat a odeslat prázdný embed s pouze hlasy. - Malé grafické úpravy Tyto změny by měly obecně prospět anketám a byly by mnohem přehlednější. Související issues: - [x] #29 - [x] #22 - [x] #21 TODO: - [x] Code cleanup - [x] Přidat type hinting - [ ] Ozkoušet a otestovat kód - [x] Přidat error handling - [x] Vyřešit bug, že `raise` keyword automaticky nepošle error. #30 bude místo, kde se bude hromadně testovat každá funkcionalita Jáchyma. Pro teď merguji.
Signed-off-by: robertsokola <robertsokola2@gmail.com>
Signed-off-by: robertsokola <robertsokola2@gmail.com>
|
Kód otestovanej, všechno se zdá být OK, v databázi na produkci je všechno připravený na tuto verzi. Hurá! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hlavní pull-request na to, aby se nakonec všechny věci zrecenzovaly a byly na jednom místě, než tyto věci dáme na produkci.
Co je nového?
Co dál dělat?
Kdo si zaslouží dík?