Merge pull request #17 from TheDragonCode/patch/2022-01-18/16-48

Added `lmc/http-constants` package
TheDragonCode · Jan 18, 2022 · 247d8da · 247d8da
2 parents fc96187 + 56c6ecb
commit 247d8da
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/composer.json b/composer.json
@@ -32,6 +32,7 @@
         "illuminate/console": "^6.0 || ^7.0 || ^8.0 || ^9.0",
         "illuminate/database": "^6.0 || ^7.0 || ^8.0 || ^9.0",
         "illuminate/support": "^6.0 || ^7.0 || ^8.0 || ^9.0",
+        "lmc/http-constants": "^1.2",
         "nesbot/carbon": "^1.20 || ^2.0",
         "psr/http-message": "^1.0.1"
     },

diff --git a/src/Services/Checker.php b/src/Services/Checker.php
@@ -24,6 +24,7 @@
 use DragonCode\LastModified\Concerns\Urlable;
 use DragonCode\Support\Concerns\Makeable;
 use Illuminate\Http\Request;
+use Lmc\HttpConstants\Header;
 
 /**
  * @method static Checker make(Request $request = null)
@@ -83,7 +84,7 @@ protected function find(): ?DateTimeInterface
 
     protected function modifiedSince()
     {
-        return $this->request->headers->getDate('If-Modified-Since');
+        return $this->request->headers->getDate(Header::IF_MODIFIED_SINCE);
     }
 
     protected function doesntRequest(): bool

diff --git a/tests/Concerns/Requests.php b/tests/Concerns/Requests.php
@@ -21,6 +21,7 @@
 
 use Carbon\Carbon;
 use Illuminate\Http\Request;
+use Lmc\HttpConstants\Header;
 
 trait Requests
 {
@@ -33,7 +34,7 @@ trait Requests
     protected function request(string $url, Carbon $date = null)
     {
         if (! empty($date)) {
-            $this->withHeader('If-Modified-Since', $date->format('r'));
+            $this->withHeader(Header::IF_MODIFIED_SINCE, $date->format('r'));
         }
 
         return $this->get($url);