drt: genApEnclosedBoundary code duplication elimination #5822
+112
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bernardo <bernardoborgessandoval@gmail.com>
Signed-off-by: bernardo <bernardoborgessandoval@gmail.com>
…ROAD into drt_minor_refactoring
Signed-off-by: bernardo <bernardoborgessandoval@gmail.com>
Signed-off-by: bernardo <bernardoborgessandoval@gmail.com>
Signed-off-by: bernardo <bernardoborgessandoval@gmail.com>
Signed-off-by: bernardo <bernardoborgessandoval@gmail.com>
Signed-off-by: bernardo <bernardoborgessandoval@gmail.com>
Signed-off-by: bernardo <bernardoborgessandoval@gmail.com>
Signed-off-by: bernardo <bernardoborgessandoval@gmail.com>
Signed-off-by: bernardo <bernardoborgessandoval@gmail.com>
Signed-off-by: bernardo <bernardoborgessandoval@gmail.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
bnmfw
changed the title
bnmfw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is branched from #5744 and is waiting for it to merge.
Like #5803, Eliminates code duplication in
genAPEnclosedBoundary.Creates the auxilary variables
coord_topandcoord_top.The old function essentially added
gtl::yh(rect) - box.yMax()andgtl::yl(rect) - box.yMin()to coords if the layer was horizontal, if not it addedgtl::xh(rect) - box.xMax()andgtl::xl(rect) - box.xMin(). It used 4 if statements, now it uses one with an auxiliary loop.