Refactor error service #7264
Merged
Refactor error service #7264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove rollbar service - ErrorService now passed in as a startOption, configuration passed to init function called on the service.
ljowen
force-pushed
the
error-service-refactor
branch
from
fdffda1
to
ee5e1ac
Compare
ljowen
force-pushed
the
error-service-refactor
branch
from
e9129f4
to
75a5abd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #7246
Remove Rollbar error service. Change error service to be instantiated externally and passed in at startup time.
Add init function to
ErrorServiceinterface which receives configTest me
Checklist
doc/.