Replace request with got #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the deprecated requests library with the got library. Unfortunately got 14.x is required for permitting followRedirect to be a function, and got 14.x requires Node 20.
pjonsson
commented
May 19, 2024
| @@ -242,7 +252,7 @@ describe('proxy', function() { | |||
| [methodName]('/https://example.com/blah') | |||
| .expect(200) | |||
| .expect(function() { | |||
| expect(fakeRequest.calls.argsFor(0)[0].proxy).toBe('http://proxy/'); | |||
| expect(fakeRequest.calls.argsFor(0)[0].agent.http.proxy).toEqual(expectedProxy); | |||
There was a problem hiding this comment.
Only changing .proxy into .agent.http.proxy made the tests fail with
Expected http://proxy/ to be 'http://proxy/'
And I have no idea why.
pjonsson
commented
May 19, 2024
| if (response.statusCode >= 300) { | ||
| return response; | ||
| } else { | ||
| return response.body.files[Object.keys(response.body.files)[0]].content; // find the contents of the first file in the gist |
There was a problem hiding this comment.
Got seems pretty compatible with request, many options have the same names.
However, I don't think this is tested by the test suite, and I have no idea if it is correct with got.
pjonsson
commented
May 19, 2024
| (response, _retryWithMergedOptions) => { | ||
| if (response.statusCode === 201) { | ||
| console.log('Created ID ' + response.body.id + ' using Gist service'); | ||
| return response.body.id; |
There was a problem hiding this comment.
Doubt this is tested by the test suite too, and I have no idea if body has an id attribute with got.
|
After running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the deprecated
requests library with the got library.
Unfortunately got 14.x is required
for permitting followRedirect to
be a function, and got 14.x requires
Node 20.