feat：流水线编辑页面，增加更多操作 #10784 #10994
Closed
feat：流水线编辑页面，增加更多操作 #10784 #10994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Reviewed, transaction id: 18876
useryuyu
requested review from
lockiechen,
terlinhe and
zhanxu33
as code owners
lockiechen
reviewed
Sep 20, 2024
| @@ -63,16 +63,44 @@ | |||
| > | |||
| <span class="debug-pipeline-draft-btn"> | |||
| {{ $t("debug") }} | |||
There was a problem hiding this comment.
这里去掉了后面的入口，没必要再弄个span标签包起来了，可以去掉，还有，对应的css也要去掉，要不然很多无用的代码在里面
| {{ $t('close') }} | ||
| </bk-button> | ||
| </footer> | ||
| </bk-dialog> |
There was a problem hiding this comment.
这里我记得有一个versionDiffEntry的组件可以复用的，不需要自己再去重复写
There was a problem hiding this comment.
这个组件我看到了，但是它还有其他的一些东西，比如头部的版本选择，而且它有个文字按钮。我这里只需要对比当前草稿和当前最新版本，只需要yaml-diff这个组件，所以就没有用versionDiffEntry组件了
| ]) | ||
| ]) | ||
| }, | ||
| async diffVersionConfirm () { |
There was a problem hiding this comment.
diffversion?? 这里应该是删除吧
There was a problem hiding this comment.
这里删除草稿有两种情况，一种是有草稿但是是那种新建的流水线没操作过的，这种删除草稿就把该条流水线删除了，另一种就是单独的删除当前草稿。我单独把两种情况写了处理方法，在删除的时候分别调用了
…o issue_10784 # Reviewed, transaction id: 19137
# Reviewed, transaction id: 19214
# Reviewed, transaction id: 19216
# Reviewed, transaction id: 19293
# Reviewed, transaction id: 19302
# Reviewed, transaction id: 19316
lockiechen
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10784