feat: 操作记录与审批功能--story=115998324 #3463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luofann
reviewed
Sep 24, 2024
bcs-services/bcs-bscp/ui/index.html
Outdated
| @@ -16,6 +16,7 @@ | |||
| var GRPC_ADDR = '{{ .GRPC_ADDR }}'; | |||
| var HTTP_ADDR = '{{ .HTTP_ADDR }}'; | |||
| var BK_NODE_HOST = '{{ .BK_NODE_HOST }}'; | |||
| var User_Man_Host = '{{ .User_Man_Host }}'; | |||
There was a problem hiding this comment.
这个变量名称是怎么定的？建议和其他变量格式保持大写字母加下划线的格式。
luofann
suggested changes
Sep 24, 2024
| * @param data 参数 | ||
| * @param publish_type 上线方式 | ||
| * @param publish_time 定时上线时间 | ||
| * @param allFirstPublish 所有待上线的分组是否为首次上线 |
| * 审批人员名单 | ||
| * @returns | ||
| */ | ||
| export const approverListApi = () => |
There was a problem hiding this comment.
这个方法是返回一个api的地址，方法名称改一下，建议用get开头
| }, | ||
| { | ||
| path: ':appId(\\d+)', | ||
| name: 'records-appId', |
There was a problem hiding this comment.
name的格式尽量保持一致，不要同时有中划线和驼峰两种命名方式
| :clearable="false" | ||
| :open="open" | ||
| type="datetimerange" | ||
| append-to-body |
| @click="open = !open"> | ||
| <template #confirm> | ||
| <div> | ||
| <bk-button theme="primary" @click="handleChange" style="margin-right: 8px; height: 26px"> 确定 </bk-button> |
| ].includes(row.audit.spec.status), | ||
| orange: row.audit.spec.status === APPROVE_STATUS.PendApproval, | ||
| }, | ||
| ]"></div> |
There was a problem hiding this comment.
- 换行
- 模板里不要写这么多的判断逻辑，直接封装一个方法，通过逻辑运算后返回对应的class名称
| } else { | ||
| tableData.value = data; | ||
| } | ||
| }; |
| name: value, | ||
| id: key, | ||
| })); | ||
| }); |
There was a problem hiding this comment.
上面三个属性都是通过导入常量来处理的，是否有必要做成计算属性？
| sendSearchData(); | ||
| }, | ||
| { deep: true }, | ||
| ); |
There was a problem hiding this comment.
慎用watch，尤其是当监听的属性有多个变化源的时候，如果逻辑复杂的话，会导致状态非常不好维护。建议在修改searchValue的地方，手动调用后续处理逻辑。
| emits('close', 'refresh'); | ||
| } catch (e) { | ||
| console.log(e); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.