feat: 添加私有化版本参数 #3317
Merged
feat: 添加私有化版本参数 #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ambition9186
force-pushed
the
feature/add_privatized_version
branch
2 times, most recently
from
d94d6a9
to
b035524
Compare
AlkaidChan
reviewed
Jul 5, 2024
Ambition9186
force-pushed
the
feature/add_privatized_version
branch
from
b035524
to
39e9adf
Compare
AlkaidChan
reviewed
Jul 9, 2024
Ambition9186
force-pushed
the
feature/add_privatized_version
branch
from
39e9adf
to
40ae3b1
Compare
AlkaidChan
reviewed
Jul 9, 2024
| @@ -135,6 +135,8 @@ type LoginAuthSettings struct { | |||
| Provider string `yaml:"provider"` | |||
| UseESB bool `yaml:"useEsb"` | |||
| GWPubKey string `yaml:"gwPubkey"` | |||
| // PrivateVersion 是否是私有化版本 | |||
| PrivateVersion bool `yaml:"privateVersion"` | |||
There was a problem hiding this comment.
上午joe提到我们要保持内外部版本一致，至少名字上不要区分内外部（私有化）
这里还是加一个大的配置项：
type ApiGateway {
AutoRegister bool // 替换现在的 PrivateVersion
PubKey string
}
Ambition9186
force-pushed
the
feature/add_privatized_version
branch
from
40ae3b1
to
21c83e2
Compare
AlkaidChan
approved these changes
Jul 9, 2024
wenxinlee2015
added a commit
that referenced
this pull request
Jul 9, 2024
* github-bk-bcs/master: feat: 添加私有化版本参数 (#3317)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.