Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pl config #28

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Add pl config #28

merged 2 commits into from
Oct 10, 2022

Conversation

kat-kan
Copy link
Contributor

@kat-kan kat-kan commented Oct 9, 2022

Description

Add Polish translation for #17

Additional comments:

  1. You can notice that there are some extra spaces in end_message for polish-panels. The reason is that panel fits end_message and thankyou_message is quite long in Polish. Without these extra spaces the program looks like this
    panels-bug
    And with extra spaces:
    panels-fixed
    This is a workaround but probably a better way is to fix cli.py to fit panels on the longer message, not always the end_message.
  2. I work on Windows and to be able to run program on my machine, I needed to add encoding on config.py (otherwise there were errors). I made a separate commit with this change. It shouldn't affect other systems and allow Windows users to run program but it is up to maintainers if they want to merge this change

Type of change

Please delete options that are not relevant. For the item that is relevant mark it completed as - [x] text here

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

running the program locally

Checklist:

Mark as completed - [x] text here

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@TechWiz-3 TechWiz-3 merged commit 0a4e142 into TechWiz-3:main Oct 10, 2022
@TechWiz-3
Copy link
Owner

This is a workaround but probably a better way is to fix cli.py to fit panels on the longer message, not always the end_message.

Thanks I'll keep that in mind and see if it can be implemeneted.

I work on Windows and to be able to run program on my machine, I needed to add encoding on config.py (otherwise there were errors). I made a separate commit with this change. It shouldn't affect other systems and allow Windows users to run program but it is up to maintainers if they want to merge this change

Thank you very much for fixing this issue, another contributor was having it and i had no clue what the issue was 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants