Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

styra-link: correct password flow #81

Merged
merged 3 commits into from
Apr 22, 2024
Merged

styra-link: correct password flow #81

merged 3 commits into from
Apr 22, 2024

Commits on Apr 17, 2024

  1. styra-link: correct password flow 

    1. fix poor error reporting upon bad password.
```
ERROR: CLI installation failed Error: Password: Sorry, try again.
Password:
sudo: no password was provided
sudo: 1 incorrect password attempt
```

2. allow password retries without re-downloading full binary
Add loop for retry but only fetch the binary on the first pass

3. cancel out of password entry closes progress bar
Move `collectInputs` out of `await IDE.withProgress`.
    @msorens
    msorens committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f0674d4 View commit details
    Browse the repository at this point in the history

  2. styra-link: cleanup 

    Duh; do not need to include the binary download in the loop at all.
    @msorens
    msorens committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f3a5753 View commit details
    Browse the repository at this point in the history

  3. bookkeeping: v2.0.1-next.4

    @msorens
    msorens committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2609318 View commit details
    Browse the repository at this point in the history