Prettify provenance output #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkwdwrd
requested review from
chendrix,
srenatus,
philipaconrad and
charlesdaniels
lkwdwrd
force-pushed
the
luke/preview-pretty-output
branch
from
d186b59
to
60b3c4a
Compare
lkwdwrd
commented
Sep 8, 2023
| } | ||
|
|
||
| if (r.printed) { | ||
| output += `PRINTED\n=======\n${r.printed}\n\n`; | ||
| output += `PRINTED\n=======\n${r.printed}\n`; |
There was a problem hiding this comment.
PR Bonus: There was an extra line added after printed lines because each ends with a new-line character. This cause three new lines instead of 2.
lkwdwrd
commented
Sep 8, 2023
| @@ -10,6 +10,7 @@ | |||
| "typescript.tsc.autoDetect": "off", | |||
| "cSpell.words": [ | |||
| "eopa", | |||
| "norc", | |||
There was a problem hiding this comment.
Author Note: ensure VS Code cspell does not complain about the name of the table style used.
srenatus
approved these changes
Sep 11, 2023
| @@ -2,7 +2,7 @@ | |||
| [](https://styracommunity.slack.com/) | |||
| [](https://www.apache.org/licenses/LICENSE-2.0) | |||
| [](#) | |||
| [](#) | |||
There was a problem hiding this comment.
Guessing this happened automatically. Interesting setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What code changed, and why?
Provenance data had a bug when initially putting pretty output together, but with that fixed the data can now be processed and output in a more human-readable format.
Definition of done
When requesting previews with provenance data, the output is formatted for human consumption rather than dumped JSON.
How to test
You can install this version from source code
Install from source
npm install.Exercise the Code
Set up an EOPA environment with preview enabled that uses bundles. Run a preview request to that environment ensuring the 'provenance' argument is set to true. Check the output to see the human-readable output.