Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch pre-compiled rebar3 instead of building it locally #16

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

kivra-pauoli
Copy link
Contributor

@kivra-pauoli kivra-pauoli commented Sep 11, 2024

This is a partial fix for #15, as well as (hopefully) issues with e.g. escript not being available at compile-time, as described in asdf-vm/actions#585.

Advantages

  • faster build time (no build, actually 😄)
  • wider Erlang version range - compatibility (since it's build for Erlang by erlang/rebar3): "The 3 newest major Erlang releases are supported at any given time: if the newest version is OTP-27, building with versions as old as OTP-25 will be supported, and produce an executable that will work with those that follow."

Advantages:

* faster build time (no build, actually)
* wider Erlang version range - compatibility
  (since it's build for Erlang <cur-2> by erlang/rebar3)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best seen with Hide whitespace enabled as part of this included changes in formatting.

@kivra-pauoli
Copy link
Contributor Author

kivra-pauoli commented Sep 11, 2024

I'll also update CI to use asdf-vm/actions and thus replicate a real user situation (erlang installed via asdf plugin)...

Edit: was trying to update the tests to work around the scenario described over at asdf-vm/actions#585, but ran into a similar issue: https://github.com/kivra-pauoli/asdf-rebar/actions/runs/10819613897/job/30017898426#step:5:46; the escript shim is available (https://github.com/kivra-pauoli/asdf-rebar/actions/runs/10819613897/job/30017898426#step:4:7152) but not even a reshim before rebar3 --version helps the test.

Edit: the workflow file for that run can be seen here.

The Ubuntu image started failing (most likely because
we're using -latest on the CI matrix)

We choose a specific version of `rebar3` that works
with the Ubuntu image (which is OTP 24) since that
one's not been updated recently
@Stratus3D
Copy link
Owner

Thanks for the PR @kivra-pauoli ! Looks good to me. I'm going to do some testing and then merge later.

@Stratus3D Stratus3D merged commit 827ef1b into Stratus3D:master Sep 12, 2024
4 checks passed
@Stratus3D
Copy link
Owner

Tested locally and seems good to me. And much faster!

@kivra-pauoli kivra-pauoli deleted the chore/pre-compiled-rebar3 branch September 19, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants