Recent change broke < v5.4 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stratus3D
reviewed
Mar 22, 2024
bin/install
Outdated
| version=$1 | ||
| IFS='.' read -ra version_array <<<"$version" | ||
| major_minor_version="${version_array[0]}0${version_array[1]}" | ||
| if (("$major_minor_version" <= 504)); then |
There was a problem hiding this comment.
This condition says less than or equal to 5.4.x, but the function name is less_than_version_5_4x. If the function name is correct this needs to become:
if (("$major_minor_version" < 504)); then
Stratus3D
reviewed
Mar 22, 2024
|
Nice catch. Fixed that now 🙏 |
|
Thanks @nulty ! |
|
Ooof. I don't know what's failing on macos there 😨 |
|
Yeah, I don't know either. But I don't think it is due to your changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/nulty/asdf-lua/actions