Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetAuthSessionTicket implementation #1407

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Masusder
Copy link

This is continuation of jesterret's pull request
I've added steam default of writing random data, as mentioned in #789 (comment) and changed code following @xPaw review
Full credits goes to @jesterret for this implementation

Here's example of successfull authentication using token generated by this implementation:

NIdHibj

@xPaw
Copy link
Member

xPaw commented Aug 27, 2024

Not really a fan of these separate UserData classes (if its always random, why does the other one even exist?)

Also put these extra classes inside of SteamAuthTicket class, not standalone.

Would love for some other users to verify that this works (commenters from the original pr?)

@Masusder Masusder requested a review from xPaw August 29, 2024 14:34
Copy link
Member

@xPaw xPaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise looks fine to me, but I have not actually tested whether this works.

Would be nice if some user actually confirmed this works.

@Masusder
Copy link
Author

Code wise looks fine to me, but I have not actually tested whether this works.

Would be nice if some user actually confirmed this works.

I unfortunately don't know anyone who could also test it. I can only mention that I've tested it on Dead by Daylight and Islands of Insight games, for both games generated ticket is accepted as valid.

@jesterret
Copy link

Thanks @Masusder for taking over the PR, I didn't have much time to look into it, and thanks @xPaw for reviewing it :)
If that would help, we could probably submit a sample project that uses the generated token to authenticate for the game?

@CLOEI
Copy link

CLOEI commented Sep 11, 2024

I just tried using it in one game, and I can confirm it works.

@xPaw xPaw requested a review from yaakov-h September 11, 2024 16:20
@xPaw xPaw added this to the 3.0.0 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants