-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetAuthSessionTicket implementation #1407
base: master
Are you sure you want to change the base?
Conversation
Credits to jesterret
SteamKit2/SteamKit2/Steam/Handlers/SteamAuthTicket/SteamAuthTicket.cs
Outdated
Show resolved
Hide resolved
Not really a fan of these separate UserData classes (if its always random, why does the other one even exist?) Also put these extra classes inside of SteamAuthTicket class, not standalone. Would love for some other users to verify that this works (commenters from the original pr?) |
SteamKit2/SteamKit2/Steam/Handlers/SteamAuthTicket/DefaultAuthTicketBuilder.cs
Outdated
Show resolved
Hide resolved
SteamKit2/SteamKit2/Steam/Handlers/SteamAuthTicket/TicketInfo.cs
Outdated
Show resolved
Hide resolved
SteamKit2/SteamKit2/Steam/Handlers/SteamAuthTicket/SteamAuthTicket.cs
Outdated
Show resolved
Hide resolved
SteamKit2/SteamKit2/Steam/Handlers/SteamAuthTicket/SteamAuthTicket.cs
Outdated
Show resolved
Hide resolved
SteamKit2/SteamKit2/Steam/Handlers/SteamAuthTicket/SteamAuthTicket.cs
Outdated
Show resolved
Hide resolved
SteamKit2/SteamKit2/Steam/Handlers/SteamAuthTicket/SteamAuthTicket.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise looks fine to me, but I have not actually tested whether this works.
Would be nice if some user actually confirmed this works.
SteamKit2/SteamKit2/Steam/Handlers/SteamAuthTicket/SteamAuthTicket.cs
Outdated
Show resolved
Hide resolved
I unfortunately don't know anyone who could also test it. I can only mention that I've tested it on Dead by Daylight and Islands of Insight games, for both games generated ticket is accepted as valid. |
I just tried using it in one game, and I can confirm it works. |
This is continuation of jesterret's pull request
I've added steam default of writing random data, as mentioned in #789 (comment) and changed code following @xPaw review
Full credits goes to @jesterret for this implementation
Here's example of successfull authentication using token generated by this implementation: