-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Planner node #6
Planner node #6
Conversation
…mprovements to simple_path_planning example
I added two important improvements:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Left a few comments on small details.
ff_path_planning/test/test_flake8.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can be removed since we are using black for style checking
ff_path_planning/test/test_pep257.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also can be removed.
ff_srvs/CMakeLists.txt
Outdated
# the following line skips the linter which checks for copyrights | ||
# comment the line when a copyright and license is added to all source files | ||
set(ament_cmake_copyright_FOUND TRUE) | ||
# the following line skips cpplint (only works in a git repo) | ||
# comment the line when this package is in a git repo and when | ||
# a copyright and license is added to all source files | ||
set(ament_cmake_cpplint_FOUND TRUE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove to enable testing
# the following line skips the linter which checks for copyrights | |
# comment the line when a copyright and license is added to all source files | |
set(ament_cmake_copyright_FOUND TRUE) | |
# the following line skips cpplint (only works in a git repo) | |
# comment the line when this package is in a git repo and when | |
# a copyright and license is added to all source files | |
set(ament_cmake_cpplint_FOUND TRUE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and incorporated changes
Adding the first draft of the path planning node.
The main path planning code is contained in
./ff_path_planning
.This node defines a path planning service, the new service definition is in
./ff_srvs
.See
./ff_path_planning/README.md
for more details.