Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reorganize estimator inheritence structure #18

Merged
merged 1 commit into from
Nov 30, 2023
Merged

reorganize estimator inheritence structure #18

merged 1 commit into from
Nov 30, 2023

Conversation

alvinsunyixiao
Copy link
Contributor

@alvinsunyixiao alvinsunyixiao commented Nov 29, 2023 •
edited
Loading

Now moving_avg_estimator_node inherit from base_mocap_estimator, which exposes the EstimateWithPose2D as a overridable function for different estimator implementations.

@joshhlee173 joshhlee173 merged commit 5864c4f into main Nov 30, 2023
3 checks passed
@joshhlee173 joshhlee173 deleted the alvin/estimator_inherit branch November 30, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshhlee173 joshhlee173 joshhlee173 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvinsunyixiao @joshhlee173