Skip to content
This repository has been archived by the owner on Jul 2, 2019. It is now read-only.

DRY: Remove unused createNPPixArrayDist. #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WillieMaddox
Copy link
Contributor

This function is also a copy of createDistanceTransform.

This function is also a copy of createDistanceTransform.
@dlindenbaum
Copy link
Collaborator

@WillieMaddox

Thank you for the pull request.

We still use that command in a couple of other places. Is it possible to instead push a change that prints that The function will be deprecated in the next release and then call the createDistanceTransform from inside?

Thank you,

@WillieMaddox
Copy link
Contributor Author

That's strange. When I do,
grep -ir createNPPixArrayDist
I only see it in one place,
utilities/python/spaceNetUtilities/labelTools.py:def createNPPixArrayDist(rasterSrc, vectorSrc, npDistFileName='', units='pixels'):
In any case, I'll submit another PR with the deprecation notice and redirect.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants