Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add second location for hackerspace drenthe #264

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

psy0rz
Copy link
Contributor

@psy0rz psy0rz commented Sep 6, 2024

We have a second location. Its the same organisation and members, but a separate location/spacestate/etc

Copy link
Member

@rnestler rnestler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://validator.spaceapi.io/ui/?url=https://mqtt.hackerspace-drenthe.nl/spaceapi-emmen

lat and lon in the location object are missing.

@rnestler
Copy link
Member

rnestler commented Sep 6, 2024

Also consider adding support for v14. See https://spaceapi.io/ for an example which is both v0.13 and v14 compatible.

I think you can just add "api_compatibility": ["14"], after adding the missing location fields.

@psy0rz
Copy link
Contributor Author

psy0rz commented Sep 9, 2024

i tried this, but now the validator gives a blank page when i check our url. (this one is still fine: https://validator.spaceapi.io/ui/?url=https://mqtt.hackerspace-drenthe.nl/spaceapi)

@psy0rz
Copy link
Contributor Author

psy0rz commented Sep 9, 2024

aha: Validate failed: error: json: cannot unmarshal string into Go struct field spaceAPIVersion.api_compatibility of type []string

@psy0rz
Copy link
Contributor Author

psy0rz commented Sep 9, 2024

ok i fixed it. it turns out the validator doesnt like it when its a string instead of an array. it also doesnt like ["0.14"] instead of ["14"].

The validator server returns a 500 but this is not properly handled in the javascript browser part. Maybe someone should fix it, so it will show the server error on the page.

@rnestler
Copy link
Member

rnestler commented Sep 9, 2024

@psy0rz Yeah sorry the validator is a bit rough when errors happen 🙁 see also SpaceApi/validator#64.

Copy link
Member

@rnestler rnestler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data looks good now, thanks 🙂

@rnestler rnestler changed the title Added second location for hackerspace drenthe Add second location for hackerspace drenthe Sep 9, 2024
@rnestler rnestler merged commit 8448653 into SpaceApi:master Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants