SLVS-1457 Open ManageBindingDialog from SharedBindingGoldBar #5699
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1457
It should have been easy: just instantiate the ManageBindingDialog in the SharedBindingSuggestionService and pass it to the goldbar. But it was a mess, because once you start adding the reference to IConnectedModeBindingServices you have a circular reference that crashes the app at runtime (the circular reference was VsSessionHost -> SharedBindingSuggestionService -> UnintrusiveBindingController -> ActiveSolutionBoundTracker -> VsSessionHost)
So I had to restructure the logic to break the circular refernce.