-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pr-status): add build status to pr-status list table #129
Merged
Dan7-7-7
merged 9 commits into
Skyscanner:main
from
jorgedc93:add_build_status_to_prstatus_table
Jun 11, 2024
Merged
feat(pr-status): add build status to pr-status list table #129
Dan7-7-7
merged 9 commits into
Skyscanner:main
from
jorgedc93:add_build_status_to_prstatus_table
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefloresr
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏼
olliecurtis
approved these changes
Mar 13, 2024
rnorth
reviewed
Mar 13, 2024
jorgedc93
force-pushed
the
add_build_status_to_prstatus_table
branch
from
March 14, 2024 08:10
53b6cb9
to
b7d713f
Compare
rnorth
previously approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
olliecurtis
approved these changes
May 20, 2024
sledigabel
reviewed
May 20, 2024
add pending status check
sledigabel
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Dan7-7-7
changed the title
Add build status to pr-status list table
feat(pr-status): add build status to pr-status list table
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the Build status to the pr-status list command using the
StatusCheckRollup
field from the github pr status command.StatusCheckRollup
contains a list with all the checks for the PR and their statuses, this is an example from a real PR with the pipeline failing:And this is an example of what the pr-status list would look like now: