Return from runE to run

Skyscanner · May 31, 2024 · eb3cac4 · eb3cac4
1 parent 413ff13
commit eb3cac4
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/cmd/foreach/foreach.go b/cmd/foreach/foreach.go
@@ -52,7 +52,7 @@ func NewForeachCmd() *cobra.Command {
 			"Make sure to include -- otherwise options will be " +
 			"interpreted as options for turbolift instead of the " +
 			"command.",
-		RunE: runE,
+		Run: run,
 		Args: cobra.MinimumNArgs(1),
 	}
 
@@ -61,7 +61,7 @@ func NewForeachCmd() *cobra.Command {
 	return cmd
 }
 
-func runE(c *cobra.Command, args []string) error {
+func run(c *cobra.Command, args []string) {
 	logger := logging.NewLogger(c)
 
 	readCampaignActivity := logger.StartActivity("Reading campaign data (%s)", repoFile)
@@ -70,7 +70,7 @@ func runE(c *cobra.Command, args []string) error {
 	dir, err := campaign.OpenCampaign(options)
 	if err != nil {
 		readCampaignActivity.EndWithFailure(err)
-		return nil
+		return
 	}
 	readCampaignActivity.EndWithSuccess()
 
@@ -108,5 +108,5 @@ func runE(c *cobra.Command, args []string) error {
 		logger.Warnf("turbolift foreach completed with %s %s(%s, %s, %s)\n", colors.Red("errors"), colors.Normal(), colors.Green(doneCount, " OK"), colors.Yellow(skippedCount, " skipped"), colors.Red(errorCount, " errored"))
 	}
 
-	return nil
+	return
 }