-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PANGOO-2594][BpkNavigationTabGroup]Fix BPK NavTabGroup Warning #3618
Conversation
Visit https://backpack.github.io/storybook-prs/3618 to see this build running in a browser. |
Browser supportIf this is a visual change, make sure you've tested it in multiple browsers. |
@@ -92,7 +92,6 @@ const SimpleCanvasDefault = () => ( | |||
onItemClick={() => {}} | |||
selectedIndex={0} | |||
type={NAVIGATION_TAB_GROUP_TYPES.CanvasDefault} | |||
ariaLabel="Navigation tabs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you decide to remove the ariaLabel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amburrrshand .Not remove it, Just change ariaLabel as optional. And this example is used for test props without ariaLabel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reasoning to make it optional?
Surely by doing this we are decreasing Accessibility for travellers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When checking header tabs on production, I found the navigation tabs did not include ariaLabel before. So I think it needs to change this ariaLabel to option. Is it reasonable for consumer decide to whether pass this ariaLabel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, I think it's best practice for accessibility standards to not have it as optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olliecurtis @amburrrshand Thank you for your advice. I have reverted the ariaLabel as required.
Visit https://backpack.github.io/storybook-prs/3618 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3618 to see this build running in a browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There is warning For BPK NavTabGroup.So need to fix.
Remember to include the following changes:
[KOA-123][BpkButton] Updating the colour
README.md
(If you have created a new component)README.md