Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BpkRadio] update Storybook example #3616

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

gert-janvercauteren
Copy link
Contributor

BpkRadio Storybook

The Storybook examples used a different name property for the radio group. This breaks the interaction with keyboard and doesn't allow for 'tabbing into' the group and then using the arrow keys to navigate around.

The change I made allows for the correct behaviour to show in our documentation website. In the future we should consider wrapping the example in a fieldset to give a proper Accessible sample.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

Copy link

Visit https://backpack.github.io/storybook-prs/3616 to see this build running in a browser.

@olliecurtis olliecurtis merged commit 102dd9b into main Sep 24, 2024
11 checks passed
@olliecurtis olliecurtis deleted the acc/fix_radio_button_demo branch September 24, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants