Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-JIRA] [BpkInsetBanner] Update stories UI styles to match docs #3592

Merged

Conversation

kirstybryce
Copy link
Contributor

@kirstybryce kirstybryce commented Aug 22, 2024

The storybook stories defined for the bpk-component-inset-banner component are using different UI styles (banner colour and logo) than the inset banner app components. This makes the styles not aligned in the backpack docs, so we want to update the styles to match the ones used by the app versions of the component.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

Copy link

Visit https://backpack.github.io/storybook-prs/3592 to see this build running in a browser.

@kirstybryce kirstybryce changed the title [NO-JIRA] bpk-component-inset-banner update stories UI to match docs [NO-JIRA] [BpkInsetBanner] Update stories UI to match docs Aug 22, 2024
@kirstybryce kirstybryce changed the title [NO-JIRA] [BpkInsetBanner] Update stories UI to match docs [NO-JIRA] [BpkInsetBanner] Update stories UI styles to match docs Aug 22, 2024
@kirstybryce kirstybryce added minor Non breaking change skip-changelog and removed skip-changelog labels Aug 22, 2024
@kirstybryce kirstybryce marked this pull request as ready for review August 22, 2024 10:36
@olliecurtis olliecurtis added skip-changelog and removed minor Non breaking change labels Aug 22, 2024
@olliecurtis olliecurtis merged commit a556858 into main Aug 27, 2024
13 of 14 checks passed
@olliecurtis olliecurtis deleted the NO-JIRA_inset-banner-update-stories-UI-to-match-docs branch August 27, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants