[NO JIRA][BpkLoadingButton]: Updating TS types and removing propTypes ahead of React 18

[olliecurtis]

As part of the migration to React 18 when running tests we found errors that were being through due to the mix of TS types and and propTypes which are deprecated and discouraged since React 17

console.error
    Warning: BpkLoadingButton: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.
        at className (/Users/olivercurtis/Documents/Backpack/backpack/packages/bpk-component-loading-button/src/BpkLoadingButton.tsx:39:11)

Remember to include the following changes:

• Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
• README.md (If you have created a new component)
• Component README.md
• Tests
• Accessibility tests
  • The following checks were performed:
    • Ability to navigate using a keyboard only
    • Zoom functionality (Deque University explanation):
      • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
      • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
    • Ability to navigate using a screen reader only
• Storybook examples created/updated
• For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

[github-actions]

Visit https://backpack.github.io/storybook-prs/3588 to see this build running in a browser.

[github-actions]

	Warnings
⚠️	Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against f3bf3e0

[amburrrshand]

Nice! Goodbye proptypes!!

[amburrrshand]

Should classname be included in the destructed props above?

[olliecurtis]

Thats a good catch! Having a deeper look, its not actually used in the component itself! So I am wondering if this was added for typing in the past but would just follow ...rest and go down to the BpkButton.

AFAIK flow/propTypes didn't have the concept of merging props with that of other components 🤔

[Sybsw]

Hey Ollie could you please explain the removals of flow strict and the changings of toMatchSnapshot ?

[olliecurtis]

As this file uses Typescript having flow in here does nothing and flow isn't installed in the repo anymore for a long time.

In terms of the snapshots, moved away from these as they aren't reliable and to use a more reliable testing over snapshots, something we advocate for in Skyscanner

[amburrrshand]

Suggested change

	iconPosition?: string,
	iconPosition?: ICON_POSITION.TRAILING || ICON_POSITION. LEADING,

[github-actions]

Visit https://backpack.github.io/storybook-prs/3588 to see this build running in a browser.

[github-actions]

Visit https://backpack.github.io/storybook-prs/3588 to see this build running in a browser.