-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LOOM-1609]: React 18 migration #3585
Changes from 14 commits
90271ac
264ded0
8561fa3
b4f6edd
a0821cb
638481b
0416b2b
4436b4a
f2d4ca5
936cbb3
1644253
30070cb
541fc28
b6f1549
769c8ad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -149,10 +149,14 @@ const reactRecogniseProp = ["React does not recognize"] | |
const invalidTags = ["The tag <rect>", "The tag <g>", "The tag <text>"] | ||
const passingTests = ["✓"] | ||
const unknownEventHandler = ["Unknown event handler"] | ||
const propType = ["Failed prop type"] | ||
const propType = ["Failed prop type", "Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.", 'A props object containing a "key" prop is being spread into JSX:'] | ||
const componentWillReceiveProps = ["componentWillReceiveProps"] | ||
const invalidCSSProperties = ["is an invalid value for the .* css style property."] | ||
const invalidProps = ["for a non-boolean attribute", "Invalid ARIA attribute"] | ||
// TODO: Address tests being wrapped in act | ||
const actTests = ["inside a test was not wrapped in act(...)"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a newly introduced warning, tests still pass and there is a few conversations open for this
As its not a blocker adding it here now and we should revisit in the future |
||
// TODO: Convert components that use CSSTransition to functional components and allow for using refs | ||
const findDOMNode = ["findDOMNode is deprecated and will be removed in the next major release."]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is coming from the underlying |
||
|
||
const allIgnoredWarnings = linterWarnings | ||
.concat(invalidReactChild) | ||
|
@@ -166,6 +170,8 @@ const allIgnoredWarnings = linterWarnings | |
.concat(componentWillReceiveProps) | ||
.concat(invalidCSSProperties) | ||
.concat(invalidProps) | ||
.concat(actTests) | ||
.concat(findDOMNode); | ||
|
||
commonFileWarnings('logs/test.log', { | ||
logType: 'fail', | ||
|
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first new addition has been added because we will need to ignore this until we have full conversion of components to Typescript.
For the second it shall be addressed in this PR or a separate one as this is new