-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LOOM-1373][BpkSlider] Comment to declare the className as an accepted prop #3375
Conversation
Browser supportIf this is a visual change, make sure you've tested it in multiple browsers. |
Visit https://backpack.github.io/storybook-prs/3375 to see this build running in a browser. |
@@ -54,7 +54,7 @@ const BpkSlider = (props: Props) => { | |||
withTracks | |||
snapDragDisabled={false} | |||
invert={invert} | |||
// TODO: className to be removed | |||
// Accepted prop passed to the next component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pop the allowed
components here:
Line 131 in 55a9215
"@skyscanner/rules/forbid-component-props": [ |
allowedFor
?
Visit https://backpack.github.io/storybook-prs/3375 to see this build running in a browser. |
…d prop (#3375) * comment to state the className is an accepted prop in bpkSlider * add reason and exclusion --------- Co-authored-by: metalix2 <matthewr@skyscanner.net>
… prop (#3373) * comment to state the className is an accepted prop in bpkModal * [LOOM-1373][BpkSlider] Comment to declare the className as an accepted prop (#3375) * comment to state the className is an accepted prop in bpkSlider * add reason and exclusion --------- Co-authored-by: metalix2 <matthewr@skyscanner.net> * add reason and exclusion --------- Co-authored-by: metalix2 <matthewr@skyscanner.net>
…d prop (#3375) * comment to state the className is an accepted prop in bpkSlider * add reason and exclusion --------- Co-authored-by: metalix2 <matthewr@skyscanner.net>
… prop (#3373) * comment to state the className is an accepted prop in bpkModal * [LOOM-1373][BpkSlider] Comment to declare the className as an accepted prop (#3375) * comment to state the className is an accepted prop in bpkSlider * add reason and exclusion --------- Co-authored-by: metalix2 <matthewr@skyscanner.net> * add reason and exclusion --------- Co-authored-by: metalix2 <matthewr@skyscanner.net>
…d prop (#3375) * comment to state the className is an accepted prop in bpkSlider * add reason and exclusion --------- Co-authored-by: metalix2 <matthewr@skyscanner.net>
… prop (#3373) * comment to state the className is an accepted prop in bpkModal * [LOOM-1373][BpkSlider] Comment to declare the className as an accepted prop (#3375) * comment to state the className is an accepted prop in bpkSlider * add reason and exclusion --------- Co-authored-by: metalix2 <matthewr@skyscanner.net> * add reason and exclusion --------- Co-authored-by: metalix2 <matthewr@skyscanner.net>
Remember to include the following changes:
[KOA-123][BpkButton] Updating the colour
README.md
(If you have created a new component)README.md
.d.ts
) files updated