Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOOM-1262 redundant BkpBannerAlertInner style removed and snapshots updated #3278

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

jronald01
Copy link
Contributor

@jronald01 jronald01 commented Mar 13, 2024

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • Type declaration (.d.ts) files updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@jronald01 jronald01 added the minor Non breaking change label Mar 13, 2024
@jronald01 jronald01 changed the title LOOM-1262 redundant BkpBannerAlertInner style remove snapshots updated LOOM-1262 redundant BkpBannerAlertInner style removed and snapshots updated Mar 13, 2024
Copy link

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 785fd50

Copy link

Visit https://backpack.github.io/storybook-prs/3278 to see this build running in a browser.

@jronald01
Copy link
Contributor Author

Warnings
⚠️
Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 785fd50

Redundant style was removed - no need to update the types: https://github.com/Skyscanner/backpack/blob/main/packages/bpk-component-banner-alert/src/BpkBannerAlertInner.d.ts

Copy link
Member

@olliecurtis olliecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jronald01 jronald01 merged commit 890d55b into main Mar 13, 2024
9 of 10 checks passed
@jronald01 jronald01 deleted the loom-1262_bkpbanneralertinner branch March 13, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants